-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhanced run image resolution #357
Enhanced run image resolution #357
Conversation
a694c3d
to
6385c28
Compare
@c0d1ngm0nk3y @pbusko thanks for this! Is it possible you could fix the DCO? I think you need to use |
b15ef28
to
1066adf
Compare
Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Pavel Busko <pavel.busko@sap.com> Signed-off-by: Ralf Pannemans <ralf.pannemans@sap.com>
1066adf
to
988d4a1
Compare
@natalieparellano could you help retarget this to an appropriate branch? |
@samj1912 sounds good. Should we be guarding this change in behavior on a Platform API version in the lifecycle? Or should this be treated more like a bug-fix and back-ported to older platforms? |
Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Signed-off-by: Ralf Pannemans <ralf.pannemans@sap.com>
988d4a1
to
d3069b8
Compare
What is missing for this to be merged? |
I believe this now has enough votes. @buildpacks/toc any further thoughts? |
??? |
I've put this on the agenda for this week's CNB Working Group. I don't see any controversy here, but I'd like clarity on this question:
|
Just to circle back here, the consensus from Working Group is that this should be safe to treat as a bug-fix. |
Merging as this has all required approvals. |
We would like to propose some enhancement to the run image resolution.
A possible implementation: buildpacks/lifecycle#1024