builder spec #363
Open
builder spec #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Kimmel <jkimmel@vmware.com>
joe-kimmel-vmw
commented
Jun 26, 2023
| @@ -15,11 +15,12 @@ This document specifies the artifact format, delivery mechanism, and order resol | |||
|
|
|||
| ## Distribution API Version | |||
|
|
|||
| This document specifies Distribution API version `0.3`. | |||
| This document specifies Distribution API version `0.4`. | |||
There was a problem hiding this comment.
I removed stacks from the labels below so I think that justifies bumping the spec version? but I left them in the builder.toml spec as a backwards compat. option for older platform APIs.
Signed-off-by: Joe Kimmel <jkimmel@vmware.com>
joe-kimmel-vmw
force-pushed
the
builders-in-distribution
branch
from
2547132
to
4d38d11
Compare
jkutner
reviewed
Jul 13, 2023
Co-authored-by: Joe Kutner <jpkutner@gmail.com> Signed-off-by: Joe Kimmel <86852107+joe-kimmel-vmw@users.noreply.github.com>
jkutner
reviewed
Jul 14, 2023
jkutner
reviewed
Jul 14, 2023
jkutner
reviewed
Jul 14, 2023
jkutner
reviewed
Jul 14, 2023
jkutner
reviewed
Jul 14, 2023
Co-authored-by: Joe Kutner <jpkutner@gmail.com> Signed-off-by: Joe Kimmel <86852107+joe-kimmel-vmw@users.noreply.github.com>
Co-authored-by: Joe Kutner <jpkutner@gmail.com> Signed-off-by: Joe Kimmel <86852107+joe-kimmel-vmw@users.noreply.github.com>
Co-authored-by: Joe Kutner <jpkutner@gmail.com> Signed-off-by: Joe Kimmel <86852107+joe-kimmel-vmw@users.noreply.github.com>
…ilder Signed-off-by: Joe Kimmel <jkimmel@vmware.com>
Signed-off-by: Joe Kimmel <jkimmel@vmware.com>
Signed-off-by: Joe Kimmel <jkimmel@vmware.com>
jkutner
reviewed
Jul 19, 2023
distribution.md
Outdated
|
|
||
| A platform supporting builders SHOULD allow users to configure the build environment for a provided builder. | ||
|
|
||
| A platform supporting builder creation MUST be able to create a valid builder from a valid builder.toml file. |
There was a problem hiding this comment.
yea, this is good. can we link to the section below? Also, not sure how to say but we don't need to require that the file be named builder.toml.
There was a problem hiding this comment.
cool - i mighta got just a little cheeky and dropped in a note about roses, but i gave a link so anyone who didn't previously read shakespeare could pick up the reference. lmk if that's too informal for the spec, I can tone it back down to corporate beige.
Signed-off-by: Joe Kimmel <jkimmel@vmware.com>
Signed-off-by: Joe Kimmel <86852107+joe-kimmel-vmw@users.noreply.github.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.