-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
builder spec #363
base: main
Are you sure you want to change the base?
builder spec #363
Conversation
Signed-off-by: Joe Kimmel <jkimmel@vmware.com>
@@ -15,11 +15,12 @@ This document specifies the artifact format, delivery mechanism, and order resol | |||
|
|||
## Distribution API Version | |||
|
|||
This document specifies Distribution API version `0.3`. | |||
This document specifies Distribution API version `0.4`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed stacks from the labels below so I think that justifies bumping the spec version? but I left them in the builder.toml spec as a backwards compat. option for older platform APIs.
Signed-off-by: Joe Kimmel <jkimmel@vmware.com>
2547132
to
4d38d11
Compare
Co-authored-by: Joe Kutner <jpkutner@gmail.com> Signed-off-by: Joe Kimmel <86852107+joe-kimmel-vmw@users.noreply.github.com>
Co-authored-by: Joe Kutner <jpkutner@gmail.com> Signed-off-by: Joe Kimmel <86852107+joe-kimmel-vmw@users.noreply.github.com>
Co-authored-by: Joe Kutner <jpkutner@gmail.com> Signed-off-by: Joe Kimmel <86852107+joe-kimmel-vmw@users.noreply.github.com>
Co-authored-by: Joe Kutner <jpkutner@gmail.com> Signed-off-by: Joe Kimmel <86852107+joe-kimmel-vmw@users.noreply.github.com>
…ilder Signed-off-by: Joe Kimmel <jkimmel@vmware.com>
Signed-off-by: Joe Kimmel <jkimmel@vmware.com>
Signed-off-by: Joe Kimmel <jkimmel@vmware.com>
distribution.md
Outdated
|
||
A platform supporting builders SHOULD allow users to configure the build environment for a provided builder. | ||
|
||
A platform supporting builder creation MUST be able to create a valid builder from a valid builder.toml file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea, this is good. can we link to the section below? Also, not sure how to say but we don't need to require that the file be named builder.toml
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool - i mighta got just a little cheeky and dropped in a note about roses, but i gave a link so anyone who didn't previously read shakespeare could pick up the reference. lmk if that's too informal for the spec, I can tone it back down to corporate beige.
Signed-off-by: Joe Kimmel <jkimmel@vmware.com>
Signed-off-by: Joe Kimmel <86852107+joe-kimmel-vmw@users.noreply.github.com>
No description provided.