-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates platform spec for stack metadata RFC #89
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's still an outstanding requirement for a label that contains any extensions/metadata that a stack author would like to add, that isn't in this list.
@kvedurmu I'm going to move this to Draft until the RFC passes. |
Makes sense @nebhale. Addressed the final comment around adding the metadata label. The one thing that wasn't clear for this field is whether this should be defined in the spec as |
Worth noting that once #87 lands this PR will need to be updated with new rebase requirements. Rebase should ensure that |
@kvedurmu This is now clear for @buildpacks/core-team review. You'll want to take forthcoming feedback and incorporate it. |
Repointed at |
@kvedurmu as part of today's discussion the following two updates have been suggested:
|
Signed-off-by: Kashyap Vedurmudi <kvedurmudi@pivotal.io> Signed-off-by: Kashyap Vedurmudi <kvedurmu@gmail.com>
Co-authored-by: Emily Casey <emilykimballcasey@gmail.com> Signed-off-by: Kashyap Vedurmudi <kvedurmu@gmail.com>
Co-authored-by: Emily Casey <emilykimballcasey@gmail.com> Signed-off-by: Kashyap Vedurmudi <kvedurmu@gmail.com>
Signed-off-by: Kashyap Vedurmudi <kvedurmu@gmail.com>
RFC - buildpacks/rfcs#78