Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: require template #75

Merged
merged 3 commits into from
Nov 29, 2023
Merged

Fix: require template #75

merged 3 commits into from
Nov 29, 2023

Conversation

newstler
Copy link
Contributor

@newstler newstler commented Nov 27, 2023 •
edited
Loading

Related to #74

We need to require Template to make injections from outside work.

@newstler newstler marked this pull request as draft November 29, 2023 16:17
@kaspth
Copy link
Contributor

kaspth commented Nov 29, 2023

What if we setup up Template as an autoload like we do for the renderer further down in the file? autoload :Renderer, "jbuilder/schema/renderer"

@newstler newstler marked this pull request as ready for review November 29, 2023 16:57
@newstler newstler force-pushed the fix/require_template_bug branch from 02ce625 to 056207a Compare November 29, 2023 17:02
@newstler newstler merged commit ba50a9a into main Nov 29, 2023
7 checks passed
@newstler newstler deleted the fix/require_template_bug branch March 22, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@newstler @kaspth