Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pedantic compile with MSVC, GCC and Clang MinGW #4623

Open
wants to merge 57 commits into
base: master
Choose a base branch
from

Conversation

RaceTheMaSe
Copy link

An attempt to build bullet3 with more pedantic compile settings for x86-64 targets

Contains:

  • A few bug fixes
  • Style changes / corrections
  • override specifier via BT_OVERRIDE macro to satisfy both C++98 and C++11 onwards

Tested compilers:

  • MSVC 2019
  • GCC 11.3
  • Clang 14 MinGW
  • Clang 17 MinGW

Tested compile settings:

  • MSVC: /W4 and disable some
  • GCC and Clang: -Wall -Wextra -Wpedantic and disable some
  • both float and double precision

As it was stated that this project should be C++98 compatible, this was the primary setting, the other C++11.

Please note that the changes are only checked so it compiles. It still works in a project that uses rather basic features of this library, so not thoroughly tested.

Integrate / cherry-pick as much as you think fits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant