Skip to content

Commit

Permalink
Allow Glide to build both release and debug variants again
Browse files Browse the repository at this point in the history
It's annoying because from Glide's perspective these are identical. However, Android Studio requires the debug variant to show syntax highlighting for instrumentation tests. Similarly the kotlin compile testing rule requires a release variant to output and validate API dumps.

It seems a lot simpler to just give in and double compile/test everything

Fixes #4881

PiperOrigin-RevId: 470288990
  • Loading branch information
sjudd authored and glide-copybara-robot committed Aug 26, 2022
1 parent 2be5834 commit f86db6f
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 9 deletions.
9 changes: 0 additions & 9 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -164,15 +164,6 @@ subprojects { project ->
signingConfig signingConfigs.debug
}
}

// It's faster to build only one variant, and debug / release
// are identical for Glide.
variantFilter { variant ->
if(variant.buildType.name == 'debug') {
variant.setIgnore(true)
}
}

}
}

Expand Down
1 change: 1 addition & 0 deletions library/test/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ tasks.withType(JavaCompile) {
afterEvaluate {
lint.enabled = false
compileReleaseJavaWithJavac.enabled = false
compileDebugJavaWithJavac.enabled = false
}

android.testOptions.unitTests.all { Test testTask ->
Expand Down

0 comments on commit f86db6f

Please sign in to comment.