Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RecyclerView integration should default to AAR instead of JAR #2053

Closed
colinrtwhite opened this issue Jun 20, 2017 · 0 comments
Closed

RecyclerView integration should default to AAR instead of JAR #2053

colinrtwhite opened this issue Jun 20, 2017 · 0 comments
Labels
bug v4
Milestone
4.0

Comments

@colinrtwhite
Copy link
Contributor

colinrtwhite commented Jun 20, 2017 •
edited
Loading

Glide Version: 4.0.0-RC0

Integration libraries: OkHttp3 and RecyclerView

Device/Android Version: This is a compile time issue.

Issue details / Repro steps / Use case background:

  • Add compile "com.github.bumptech.glide:recyclerview-integration:4.0.0-RC0" to your build.gradle file.
  • Result: Gradle error: Error: Module 'com.github.bumptech.glide:recyclerview-integration:4.0.0-RC0' depends on one or more Android Libraries but is a jar
  • Expectation: Glide should default to the AAR version of the integration by default like the other Glide components.
  • Note: You can manually depend on the AAR by using compile "com.github.bumptech.glide:recyclerview-integration:4.0.0-RC0@aar"
sjudd added a commit to sjudd/glide that referenced this issue Jun 20, 2017
@sjudd
Update the documentation in RequestListener.
d024ea7 
RequestListener is called before Targets so that
it has the option of overriding the Target’s 
behavior.

bumptech#2053
@sjudd sjudd added this to the 4.0 milestone Jun 20, 2017
@sjudd sjudd closed this as completed in 42dd24b Jun 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug v4
Projects
None yet
Milestone
4.0
Development

No branches or pull requests
2 participants
@sjudd @colinrtwhite