-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JNI error on AVIF - runtime crash on 4.13.1 #4761
Comments
Thanks for mentioning this. This could be the case. I will look into the proguard settings for JNI. |
I am able to reproduce the issue with minifyEnabled set to true. Will fix soon. Tracking internally as b/224576412. |
Without this change, proguard will obfuscate members of the Info class, which is being accessed by the native methods. The native JNI code will crash as it will not be able to find the members with their original names. Fixes bumptech/glide#4761.
The update fixes proguard stripping/obfuscating of native code and java members that are being accessed from native code. Fixes Github issue #4761. PiperOrigin-RevId: 434569408
The update fixes proguard stripping/obfuscating of native code and java members that are being accessed from native code. Fixes Github issue #4761. PiperOrigin-RevId: 434569408
The update fixes proguard stripping/obfuscating of native code and java members that are being accessed from native code. Fixes Github issue #4761. PiperOrigin-RevId: 434569408
The update fixes proguard stripping/obfuscating of native code and java members that are being accessed from native code. Fixes Github issue #4761. PiperOrigin-RevId: 434574974
This issue is now fixed and should be available in the next glide release. In the meantime, if you would like to pick up the fix, you could depend directly on the updated version of libavif by including the following in your build.gradle as a temporary solution:
|
Directly adding the dependency is not working as somehow gradle is picking the older commit sha only... it worked after I added the proguard rules though |
when can we expect this to be released? |
same issue i am facing also. Kindly make the release. Thanks. |
|
@oluwabajio yeah it is the same issue that was fixed. i will get back to you about the tagged release soon. thanks! |
The update fixes proguard stripping/obfuscating of native code and java members that are being accessed from native code. Fixes Github issue bumptech#4761. PiperOrigin-RevId: 434574974
Tagged release 4.13.2 should fix AVIF related issues: https://github.com/bumptech/glide/releases/tag/v4.13.2 |
Glide Version: 4.13.1
Integration libraries: Okhttp-4.9.0
Device/Android Version: Samsung M30s/10
Issue details / Repro steps / Use case background: App is crashing while using latest glide with AVIF integration.
Glide load line /
GlideModule
(if any) / list Adapter code (if any):Layout XML:
Stack trace / LogCat:
The text was updated successfully, but these errors were encountered: