Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

findActivity(view) to findActivity(contentView) ,because The view.con… #4882

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

weiyfwork
Copy link

Description

findActivity(view) to findActivity(contentView)

Motivation and Context

The view.context might not be current Activity.

for example:
View viewA = LayoutInflater.from(activityA).inflate(resId, activityA.viewGroupA, false)
activityB.viewGroupB.addView(viewA)
viewA.context == activityA

Although rarely used in this way, it does exist, The lifecycle of activityB should be bound, but the lifecycle of activityA is bound.

…text might not be current Activity.

for example:
View viewA = LayoutInflater.from(activityA).inflate(resId, activityA.viewGroupA, false)
activityB.viewGroupB.addView(viewA)
(viewA.context == activityA) = true
@google-cla
Copy link

google-cla bot commented Aug 24, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant