Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid modifying constraints when a scale factor can't be computed #5264

Merged
merged 2 commits into from
Aug 24, 2023

Conversation

sjudd
Copy link
Collaborator

@sjudd sjudd commented Aug 24, 2023

This will happen if either width or height (or both) are constrained to have a 0 size.

We already avoid loading the image via AsyncImageSize / inferredGlideSize. This only impacts layout.

Fixes #5256

This will happen if either width or height (or both) are constrained to
have a 0 size.

We already avoid loading the image via AsyncImageSize /
inferredGlideSize. This only impacts layout.

Fixes #5256
@sjudd sjudd enabled auto-merge (rebase) August 24, 2023 01:57
@sjudd sjudd merged commit af0d631 into master Aug 24, 2023
7 checks passed
@sjudd sjudd deleted the fix_crash_with_zero_image_Size branch August 24, 2023 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash in glide compose alpha.5, when computing scale factor
1 participant