Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update zh_Hant for licensing #289

Merged
merged 5 commits into from
Mar 23, 2024
Merged

Conversation

sh95014
Copy link
Contributor

@sh95014 sh95014 commented Mar 22, 2024

  1. The "Buy Cork for 25€" UI is problematic for translations. In Chinese it would be less awkward to phrase it as "以 25 歐元 購買 Cork" but that requires a code change. I suggest you move the "for 25€" into the button.

  2. While running the app to test the translations, it seems that a user will now be blocked from using the app (beyond the 7-day trial) unless they purchase. You 100% deserve to be paid for your work, but I also don't feel the need to contribute my efforts to a paid app going forward. Best of luck!

  3. Same issue with README.md as the other PR.

@sh95014 sh95014 changed the title update zh_Hant update zh_Hant for licensing Mar 22, 2024
Copy link
Owner

@buresdv buresdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

Concerning point 2, you'd maintain free access to Cork, just as all the other developers do. There's also the self-compilation route, which will still always be free. Esentially, nothing changes from how it was before, only now the people who bought the app themselves (and are not contributors) have to validate their emails.

Nevertheless, if that doesn't change your mind, you're free to stop contributing and I'd like to thank you for all your efforts 😊

@buresdv buresdv merged commit a071c6d into buresdv:licensing Mar 23, 2024
@sh95014
Copy link
Contributor Author

sh95014 commented Mar 23, 2024

Yup, it's great that you're keeping the source open, which makes the paywall easy to bypass for a developer anyway. Just to clarify, my motivations are mainly:

  1. If zh_Hant is actually important, you should hire a real translator now that Cork will have a revenue.
  2. I don't want the implicit responsibility of supporting paid users.

But I wish you great success!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants