Replace deprecated getDrawingCache to capturing method.
#324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- getDrawingCache is deprecated. - getDrawingCache raises burhanrashid52#284 - PixelCopy is better way. But it needs window instance.
|
CI build failed, but when I tested it locally, it worked. |
|
Changes look good. Have you tested this with different devices ? |
|
I tested it on Galaxy S20+, Pixel(emulator). It works. |
burhanrashid52
approved these changes
Mar 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
getDrawingCacheis deprecated and it occurs error #284.How should we fix it?
Google suggests to use PixelCopy instead of getDrawingCache. But it requires window instance. It is difficult to get a window instance without the dependency of an activity or fragment.
So, as the next best thing, I drew a bitmap of the view on the canvas.