-
Notifications
You must be signed in to change notification settings - Fork 948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial typing in client.py #1159
Initial typing in client.py #1159
Conversation
Hi you can ise the following command to format the entire code and pass the linter: |
The issue seems to be with the imports in exceptions.py and cell.py. Should I commit those changes to this PR? Also, tox sees this line |
I see, I did not finish my fishes on I'll let you know when you can rebase. sorry for the inconvenience |
✔️ I pushed the necessary changes to make the CI green again on the branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for this contribution, here are a few comments, mostly about JSON to be typed as Any because it's a nightmare to maintain.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
last changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. Looks good to me. I'll run mypy on it when I get z Chance
Not fully certain about some of the type hints, especially regarding
Client.request()
.