Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add legacy option for DateTimeOption #1205

Closed
wants to merge 2 commits into from

Conversation

alifeee
Copy link
Collaborator

@alifeee alifeee commented Jun 5, 2023

now, someone can use the correct (new) spelling, or the incorrect (old) spelling
this is thus not longer a breaking change

See #1187 for further discussion

now, someone can use the correct (new) spelling, or the incorrect (old) spelling
this is thus not longer a breaking change
@alifeee alifeee requested a review from lavigne958 June 5, 2023 19:00
Copy link
Collaborator

@lavigne958 lavigne958 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great thank you !

You can change the base branch of your PR to target the main branch, this way we can make everyone benefits from this change.

Once the base branch is updated I'll merge it.

@lavigne958 lavigne958 added this to the 5.10 milestone Jun 6, 2023
@alifeee alifeee changed the base branch from feature/release_6_0_0 to master June 6, 2023 21:48
@alifeee alifeee changed the base branch from master to feature/release_6_0_0 June 6, 2023 21:49
@alifeee
Copy link
Collaborator Author

alifeee commented Jun 6, 2023

hmm. I think I will have to change the original pull request branch.

@alifeee
Copy link
Collaborator Author

alifeee commented Jun 6, 2023

Superseded by #1210

@alifeee alifeee closed this Jun 6, 2023
@alifeee alifeee deleted the fix/spelling-fix-legacy-update branch June 6, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants