Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update self._properties after batch_update #1221

Merged
merged 1 commit into from
Jun 14, 2023
Merged

update self._properties after batch_update #1221

merged 1 commit into from
Jun 14, 2023

Conversation

alifeee
Copy link
Collaborator

@alifeee alifeee commented Jun 14, 2023

this is how other methods like update_title and update_index do it. means that the request must succeed to update internal props.

@alifeee alifeee requested review from lavigne958 and removed request for lavigne958 June 14, 2023 14:34
@alifeee alifeee merged commit 2bef750 into master Jun 14, 2023
@alifeee alifeee deleted the fix/_set_gridlines_hidden_flag branch June 14, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alifeee