-
Notifications
You must be signed in to change notification settings - Fork 952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update-build-tools #1231
Update-build-tools #1231
Conversation
It is supposed to declare files to include/exclude when built (with setuptools) I rebuilt the project without the file Files in MANIFEST.in remained in the source sdist It is no longer needed https://stackoverflow.com/questions/24727709/do-python-projects-need-a-manifest-in-and-what-should-be-in-it
previously this was done in the file with `# flake8: noqa`
I have simplified the required python versions old Line 55 in 88883ef
new Line 30 in 7f12b2d
Firstly, Python 3.6 support is removed. Secondly, the signature is simplified. To me, all rules specifying against Python versions less than 3.7, are specified by specifying at least 3.7 is required. If this is not the case, we can change it back. |
was used for old build, no longer needed
I have replaced Changes:
|
PyPiTo see the comparison of old project metadata vs new project metadata practically, see the new project on test PyPi (note, package name is old https://test.pypi.org/project/gspread/ new |
Updated build filesTo compare the new https://github.com/alifeee/gspread-new-build/compare/old-build...main |
This seems good to me. I cannot think of much more to check, it would be good to hear your thoughts. Then, I will check anything you think might cause an issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, I Just have a question about linting and skipping files.
closes #1218
Move from using
setup.py
topyproject.toml