Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update-build-tools #1231

Merged
merged 9 commits into from
Jun 24, 2023
Merged

Update-build-tools #1231

merged 9 commits into from
Jun 24, 2023

Conversation

alifeee
Copy link
Collaborator

@alifeee alifeee commented Jun 19, 2023

closes #1218

Move from using setup.py to pyproject.toml

alifeee added 6 commits June 19, 2023 13:23
It is supposed to declare files to include/exclude when built
(with setuptools)
I rebuilt the project without the file
Files in MANIFEST.in remained in the source sdist
It is no longer needed
https://stackoverflow.com/questions/24727709/do-python-projects-need-a-manifest-in-and-what-should-be-in-it
previously this was done in the file with `# flake8: noqa`
@alifeee
Copy link
Collaborator Author

alifeee commented Jun 19, 2023

I have simplified the required python versions

old

python_requires=">=3.6, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*",

new

requires-python = ">=3.7"

Firstly, Python 3.6 support is removed.

Secondly, the signature is simplified. To me, all rules specifying against Python versions less than 3.7, are specified by specifying at least 3.7 is required. If this is not the case, we can change it back.

@alifeee alifeee mentioned this pull request Jun 19, 2023
6 tasks
@alifeee
Copy link
Collaborator Author

alifeee commented Jun 19, 2023

I have replaced setup.py with pyproject.toml.

Changes:

@alifeee
Copy link
Collaborator Author

alifeee commented Jun 19, 2023

PyPi

To see the comparison of old project metadata vs new project metadata practically, see the new project on test PyPi (note, package name is gspreadalifeee because I did not have permission to push to gspread)

old

https://test.pypi.org/project/gspread/

new

https://test.pypi.org/project/gspreadalifeee/

@alifeee
Copy link
Collaborator Author

alifeee commented Jun 19, 2023

Updated build files

To compare the new sdist files, you could download and compare from the test.pypi links above, or see this diff

https://github.com/alifeee/gspread-new-build/compare/old-build...main

@alifeee alifeee requested a review from lavigne958 June 19, 2023 15:56
@alifeee
Copy link
Collaborator Author

alifeee commented Jun 19, 2023

This seems good to me. I cannot think of much more to check, it would be good to hear your thoughts. Then, I will check anything you think might cause an issue.

@alifeee alifeee added this to the 5.10 milestone Jun 21, 2023
Copy link
Collaborator

@lavigne958 lavigne958 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, I Just have a question about linting and skipping files.

tox.ini Show resolved Hide resolved
@alifeee alifeee marked this pull request as ready for review June 24, 2023 16:43
@alifeee alifeee merged commit b9450af into master Jun 24, 2023
@alifeee alifeee deleted the update-build-tools branch June 24, 2023 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update tox -e build script
2 participants