-
Notifications
You must be signed in to change notification settings - Fork 948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Worksheet ID Type Inconsistencies #1269
Conversation
thanks for the PR! Great work :) Some automated tests fail because of old Python versions. You need to replace For the tests, try this:
This will run the test online (with real API requests). When you are happy - or the test passes - either clear the env variables or start a fresh console and run the test command(s) again. Let me know if you need any more help with testing. Again thanks for the PR! I have left some other comments as code comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the changes :)
it is great that you write tests
This looks good. You have a merge conflict with your the cassettes. I would perhaps just try deleting the test cassette (json file) and re-running the tests, rather than trying to fix it manually. After that's fixed, I will have another look :) |
So I deleted the .json's, re-ran tests, and pushed the commit with the new ones and now it looks like there's still merge commits but they're subtly different... It seems to me like the conflicts are just the headers coming in a different order in the file than the existing versions which maybe doesn't matter? |
the merge conflict was my fault haha. I merged a seperate PR earlier today, but after you opened this. I have fixed it for you. It all looks good now! |
good timing lol, I was just about to go through and do some copy paste hijinks to resolve it. |
thanks so much for this PR. It should be implemented in the next version (v10) in a few weeks. I consider it good, so once @lavigne958 reviews this we will merge it. |
Awesome, thanks for your help @alifeee |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for this contribution 👍
Implements #1267
I'm not super familiar with VCR tests so I hope adding
allow_playback_repeats=True
is acceptable in this case.closes #1267