Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): strenum dependency only installed for Python versions be… #1340

Conversation

bpshaver
Copy link

…low 3.11

…low 3.11

Signed-off-by: Ben Shaver <benpshaver@gmail.com>
This was referenced Oct 31, 2023
@lavigne958
Copy link
Collaborator

Hi, thank you for your contribution, I'm sorry but I don't understand why we should select a different import depending on the python version.
I check the Pypi page of StrEnum and it works for python version from 3.8 to 3.12 the same way, see here: https://pypi.org/project/StrEnum/

@bpshaver
Copy link
Author

bpshaver commented Nov 1, 2023

No problem. Its just unnecessary to install strenum via pip if the end user is running Python 3.11 or above.

Edit: You can probably assume strenum will continue to work without any bugs or security issues in all future versions of Python, but that is just an assumption.

@lavigne958
Copy link
Collaborator

No problem. Its just unnecessary to install strenum via pip if the end user is running Python 3.11 or above.

Edit: You can probably assume strenum will continue to work without any bugs or security issues in all future versions of Python, but that is just an assumption.

I understand better now, thank you for pointing out that part.

We need to be compliant with 5 different version of python, as much as we can we try not to introduce python version specific code. so far if installing the extra library works for all versions and is mandatory for any version bellow 3.11 we'll keep it and remove that dependency once we only handle version 3.11 and onward. this will keep it easier for us to maintain.

hope you understand.

@bpshaver
Copy link
Author

bpshaver commented Nov 1, 2023

Of course! It is an interesting but ultimately minor decision.

I tend to believe explicit is better than implicit but there are other bits from the Zen of Python would point the other way in this, e.g. beautiful is better than ugly.

And pinning to a specific version (==0.4.15) is likely to address some issues, too.

@bpshaver bpshaver closed this Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants