Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix 1352 expected headers broken #1353

Merged
merged 5 commits into from
Nov 20, 2023
Merged

fix 1352 expected headers broken #1353

merged 5 commits into from
Nov 20, 2023

Conversation

alifeee
Copy link
Collaborator

@alifeee alifeee commented Nov 15, 2023

closes #1352

See #1352 for more information.

  • make expected_headers test fail (by making headers duplicate)
  • fix test (by moving unique check to the if expected_headers == None branch)

@alifeee alifeee added the Bug label Nov 15, 2023
@alifeee alifeee added this to the 5.12.1 milestone Nov 15, 2023
@alifeee alifeee self-assigned this Nov 15, 2023
@alifeee alifeee mentioned this pull request Nov 15, 2023
Closed
@alifeee alifeee merged commit 0932358 into master Nov 20, 2023
12 checks passed
@alifeee alifeee deleted the 1352-expected-headers branch November 20, 2023 12:12
@alifeee alifeee mentioned this pull request Nov 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lavigne958 lavigne958 lavigne958 approved these changes

Assignees

@alifeee alifeee

Labels
Bug
Projects
None yet
Milestone
5.12.1
Development

Successfully merging this pull request may close these issues.

get_all_records with unique expected_headers fails in version 5.12
2 participants
@alifeee @lavigne958