Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add insert_cols method to worksheet #802

Merged
merged 1 commit into from
Oct 20, 2020

Conversation

AlexeyDmitriev
Copy link
Contributor

Closes #798

@AlexeyDmitriev
Copy link
Contributor Author

AlexeyDmitriev commented Jul 29, 2020

cols is used more often then columns in this class so I went ahead and called it insert_cols, not insert_columns. Let me know if you think that I should rename it.

Also, I think it makes sense to either add insert_col(umn) or make insert_row deprecated for consistency

@AlexeyDmitriev AlexeyDmitriev marked this pull request as draft August 12, 2020 13:58
@AlexeyDmitriev AlexeyDmitriev marked this pull request as ready for review August 12, 2020 13:58
@iisulop
Copy link

iisulop commented Oct 9, 2020

Hi,
I would love to get to use this. Is there still something requiring action?

@burnash burnash merged commit 52eef45 into burnash:master Oct 20, 2020
@burnash
Copy link
Owner

burnash commented Oct 20, 2020

Thank you very much for the PR. Yes, I think it makes more sense to deprecate insert_row() to remove duplicate functionality.

@lavigne958
Copy link
Collaborator

closes #576

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inserting columns
4 participants