Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use text+datalist for "Add Ranger", rather than select #1292

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

srabraham
Copy link
Member

@srabraham srabraham commented Oct 2, 2024

This has various benefits over the current select dropdown:

  • You can search by substring, e.g. on a second word or on real names. The current way only lets you scan the dropdown with prefixes
  • If you know the Ranger handles, you can just type them (e.g. "Abraham", enter, "Tool", enter, to add both of those callsigns)
  • Removes the glitchy thing where you can accidentally add a bunch of random Rangers if you type while the select field is highlighted

@srabraham srabraham force-pushed the 2024-10-02-datalist-add-rangers branch from 8cbe568 to 2ecb93b Compare October 2, 2024 14:16
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.01%. Comparing base (c0fb13b) to head (c23348c).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1292   +/-   ##
=======================================
  Coverage   69.01%   69.01%           
=======================================
  Files         181      181           
  Lines        8869     8869           
  Branches     1484     1484           
=======================================
  Hits         6121     6121           
  Misses       2648     2648           
  Partials      100      100           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This makes it a lot simpler to add Rangers than with the huge
select dropdown of before.
@wsanchez
Copy link
Member

wsanchez commented Oct 9, 2024

Oooh, cool. OK.

@wsanchez wsanchez merged commit f1ba90b into master Oct 9, 2024
14 checks passed
@wsanchez wsanchez deleted the 2024-10-02-datalist-add-rangers branch October 9, 2024 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants