Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add warning banner on non-prod IMS instances #1390

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

srabraham
Copy link
Member

@srabraham srabraham commented Nov 11, 2024

Frankenstein already added the relevant env var to prod and staging

#1366

Example below. The banner only shows up if the deployment is not prod.

image

@srabraham srabraham requested a review from wsanchez November 11, 2024 18:12
@srabraham srabraham force-pushed the 2024-11-11-deployment-warning branch from 7bcf279 to 3a50545 Compare November 11, 2024 18:13
Copy link
Contributor

github-actions bot commented Nov 11, 2024

⚠️ Optional matrix job Py:3.14.0-alpha.1 - ubuntu-latest failed ⚠️

  • tox prefix: test
  • exit status: 1

@srabraham srabraham force-pushed the 2024-11-11-deployment-warning branch from 3a50545 to 6ac38f2 Compare November 11, 2024 18:13
@srabraham srabraham requested a review from mikeburg November 11, 2024 18:15
@srabraham srabraham force-pushed the 2024-11-11-deployment-warning branch from 6ac38f2 to bdb71d6 Compare November 11, 2024 18:26
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 69.15%. Comparing base (7b396e6) to head (32b3ff8).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/ims/element/_element.py 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1390      +/-   ##
==========================================
- Coverage   69.21%   69.15%   -0.07%     
==========================================
  Files         181      181              
  Lines        8921     8929       +8     
  Branches     1491     1493       +2     
==========================================
  Hits         6175     6175              
- Misses       2647     2654       +7     
- Partials       99      100       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@srabraham srabraham force-pushed the 2024-11-11-deployment-warning branch from bdb71d6 to 32b3ff8 Compare November 11, 2024 21:38
@srabraham srabraham enabled auto-merge (rebase) November 11, 2024 21:38
@srabraham srabraham merged commit ccd7cb0 into master Nov 11, 2024
11 checks passed
@srabraham srabraham deleted the 2024-11-11-deployment-warning branch November 11, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant