fail if the current Go version is newer than what built garble #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdan
force-pushed
the
goversion-built-check
branch
from
afc1581 to
931454d
Compare
For instance, Go 1.18 added support for generics, so its compiler output files changed format to accomodate for the new language feature. If garble is built with Go 1.17 and then used to perform builds on Go 1.18, it will fail in a very confusing way, because garble's go/types and go/importer packages will not know how to deal with that. As already discussed in burrowers#269, require the version that built the garble binary to be equal or newer. In that thread we discussed only comparing the major version, so for example garble built on go1.18 could be used on the toolchain go1.18.5. However, that could still fail in confusing ways if a fix to go/types or go/importer happened in a point release. While here, I noticed that we were still using Go 1.17 for some CI checks. Fix that, except for staticcheck. Fixes burrowers#269.
mvdan
force-pushed
the
goversion-built-check
branch
from
931454d to
de2e14f
Compare
lu4p
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(see commit message)
Fixes #269.