obfuscate all assembly filenames #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @Ne0nd0g |
We were still leaking the filenames for assembly files. In our existing asm.txtar test's output binary, the string `test/main/garble_main_amd64.s` was present. This leaked full import paths on one hand, and the filenames of each assembly file on the other. We avoid this in Go files by using `/*line` directives, but those are not supported in assembly files. Instead, obfuscate the paths in the temporary directory. Note that we still need a separate temporary directory per package, because otherwise any included header files might collide. We must remove the `main` package panic in obfuscatedImportPath, as we now need to use that function for all packages. While here, remove the outdated comment about `-trimpath`. Fixes burrowers#605.
mvdan
force-pushed
the
obfuscate-asm-filenames
branch
from
78e3070 to
3e192f9
Compare
lu4p
approved these changes
Nov 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(see commit message)
Fixes #605.