Make the plugin work with AWS SSO #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlsi
reviewed
Sep 7, 2022
…ration Co-authored-by: Vladimir Sitnikov <sitnikov.vladimir@gmail.com>
|
Thank you for the fix. I've pushed 1.4, enjoy: https://plugins.gradle.org/plugin/com.github.burrunan.s3-build-cache |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using AWS SSO login feature to authenticate our S3 instance.
This plugin just doesn't work with SSO by setting
lookupDefaultAwsCredentials = true, forcing clients to configure the plugin withawsAccessKeyId,awsSecretKeyandsessionToken.We found out that just by adding the AWS SSO dependency will make the plugin work with no extra effort.
This StackOverflow answer helped us.
As a workaround we have now added the same dependencies (BOM and SSO) to our
settings.gradleasbuildscript.dependencies.classpath, but it would be nice if it was supported by this plugin out of the box.I took the opportunity to update AWS but feel free to revert that change.