Add support for AWS profile in remote cache DSL #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the remote cache configuration to use a profile name when obtaining AWS credentials. Profiles are an alternate way to provide credentials. The current method of doing this is to set `lookupDefaultAwsCredentials=true` and the environment variable `export AWS_PROFILE="<profile_name>"`, but this requires each developer to set that variable. Moving it into the remote cache configuration allows that setting to be more easily shared, particularly in environments that used shared managed profiles. More about using profiles at https://docs.aws.amazon.com/sdk-for-java/latest/developer-guide/credentials-profiles.html
|
Fixed in 1.6, enjoy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is relatively simple, more info in the commit message. But I haven't been able to build locally. Something about not having Kotlin set up properly for this. That being said, I'd appreciate if you'd take a look at it and verify. It's minor, but it would be a huge quality of life improvement for us.