Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix package lookup in Cargo metadata #139

Merged
merged 1 commit into from
Mar 17, 2023

Conversation

slonopotamus
Copy link
Contributor

Broken by a33aee1

@mdsteele
Copy link
Collaborator

Thanks! Looks reasonable; please just fix the clippy error?

@mdsteele mdsteele merged commit eb9fe1b into burtonageo:master Mar 17, 2023
@slonopotamus slonopotamus deleted the cargo-metadata-lookup branch March 18, 2023 07:59
@stepbrobd
Copy link

I think this PR does not fix #138:

On aarch64-apple-darwin:

$ cat Cargo.toml
...
[package.metadata.bundle]
name = "Neovide"
identifier = "com.neovide.neovide"
icon = ["assets/neovide.ico"]
version = "0.10.0"
resources = []
copyright = "Copyright (c) Keith 2021. All rights reserved."
category = "Productivity"
short_description = "A simple GUI for Neovim."
long_description = """
This is a simple graphical user interface for Neovim. Where possible there are some graphical improvements, but it should act functionally like the terminal UI.
"""
osx_minimum_system_version = "10.11"
$ cargo bundle
error: No [package.metadata.bundle] section in Cargo.toml
^^^^^

I'm using cargo-bundle commit eb9fe1b0880c7c0e929a93edaddcb0a61cd3f0d4 introduced in NixOS/nixpkgs#222461.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants