AppImage support #181
Open
AppImage support #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmayoff
commented
May 3, 2024
| @@ -39,7 +39,7 @@ fn symlink_dir(src: &Path, dst: &Path) -> io::Result<()> { | |||
| } | |||
|
|
|||
| #[cfg(unix)] | |||
| fn symlink_file(src: &Path, dst: &Path) -> io::Result<()> { | |||
| pub fn symlink_file(src: &Path, dst: &Path) -> io::Result<()> { | |||
There was a problem hiding this comment.
I'm not sure if there's another intended way to do this
There was a problem hiding this comment.
Not sure if I just missed another way of doing this, but AppDir specifies you can symlink the .desktop file and the icons to the AppDir root
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this should close #75. It's not quite done yet but does work (want to cleanup). AppImages require two things, the AppDir and the AppImage runtime; I found a couple of ways of setting this up, and went with what I thought was the best.
Other similar implementations
This mimicks the last one downloading the runtime when bundling, but doesn't cache it.