Merge pull request #621 from buschtoens/fix-tests

Make tests pass and CI green

.github/workflows/ci.yml

@@ -64,6 +64,7 @@ jobs:
         try-scenario:
           - ember-lts-4.12
           - ember-lts-5.4
+          - ember-lts-5.8
           - ember-release
           - ember-beta
           - ember-canary
@@ -83,3 +84,4 @@ jobs:
         run: pnpm install --frozen-lockfile
       - name: Run Tests
         run: ./node_modules/.bin/ember try:one ${{ matrix.try-scenario }}
+        working-directory: test-app

ember-lazy-mount/.template-lintrc.js

@@ -1,5 +1,5 @@
 'use strict';
 
 module.exports = {
-  extends: 'recommended'
+  extends: 'recommended',
 };

ember-lazy-mount/package.json

@@ -18,8 +18,6 @@
   },
   "scripts": {
     "lint": "concurrently \"pnpm:lint:*(!fix)\" --names \"lint:\"",
-    "lint:css": "stylelint \"**/*.css\"",
-    "lint:css:fix": "concurrently \"pnpm:lint:css -- --fix\"",
     "lint:fix": "concurrently \"pnpm:lint:*:fix\" --names \"fix:\"",
     "lint:hbs": "ember-template-lint .",
     "lint:hbs:fix": "ember-template-lint . --fix",
@@ -56,9 +54,6 @@
     "prettier": "^3.3.2",
     "rsvp": "^4.8.5",
     "qunit-dom": "^3.2.0",
-    "stylelint": "^15.11.0",
-    "stylelint-config-standard": "^34.0.0",
-    "stylelint-prettier": "^4.1.0",
     "webpack": "^5.92.1"
   },
   "peerDependencies": {

package.json

@@ -1,21 +1,11 @@
 {
   "private": true,
-  "workspaces": [
-    "ember-lazy-mount",
-    "test-app",
-    "test-engine"
-  ],
   "scripts": {
-    "lint": "concurrently 'pnpm:lint:*(!fix)' --names 'lint:'",
-    "lint:fix": "concurrently 'pnpm:lint:*:fix' --names 'fix:'",
-    "lint:js": "eslint . --cache",
-    "lint:js:fix": "eslint . --fix",
-    "prepack": "concurrently 'pnpm:build:*'",
+    "lint": "pnpm --filter '*' lint",
+    "lint:fix": "pnpm --filter '*' lint:fix",
     "test": "pnpm --filter '*' test"
   },
-  "devDependencies": {
-    "concurrently": "^8.2.2"
-  },
+  "devDependencies": {},
   "packageManager": "pnpm@8.15.8",
   "volta": {
     "node": "18.20.4"

pnpm-workspace.yaml

@@ -1,4 +1,5 @@
 packages:
   - 'ember-lazy-mount'
   - 'test-app'
-  - 'test-engine'
+  - 'test-engine1'
+  - 'test-engine2'

test-app/config/ember-try.js

@@ -23,6 +23,14 @@ module.exports = async function () {
           },
         },
       },
+      {
+        name: 'ember-lts-5.8',
+        npm: {
+          devDependencies: {
+            'ember-source': '~5.8.0',
+          },
+        },
+      },
       {
         name: 'ember-release',
         npm: {

test-app/package.json

@@ -72,6 +72,8 @@
     "stylelint": "^15.11.0",
     "stylelint-config-standard": "^34.0.0",
     "stylelint-prettier": "^4.1.0",
+    "test-engine1": "workspace:*",
+    "test-engine2": "workspace:*",
     "tracked-built-ins": "^3.3.0",
     "webpack": "^5.92.1"
   },