Split shortcuts by platform and name them #591
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main task of this pull request is to name the default shortcuts.
I think the default shortcuts are not bad, but if you want to use mobiledoc kit as a framework you need a way to reset the shortcuts and not just overwrite them. (For example, if you do not want to support underlined text)
You already have the
unregisterKeyCommands()
function to delete key commands. Unfortunately, the shortcuts need a name property to delete them. This is what I did for the default commands.Some of them had different functions, depending on the platform. This is why I split the arrays into a mac and a windows array. This way I could give them distinctive names.