Skip to content
This repository has been archived by the owner on Oct 21, 2024. It is now read-only.

Slack Block Kit UI for Daily GitHub Summary #253

Merged
merged 22 commits into from
Apr 18, 2020

Conversation

alysivji
Copy link
Member

What does this do

Slack Block Kit is a UI framework for building native Slack experiences.

We were posting Daily GitHub Summary reports in Markdown. Porting over current functionality to Block Kit will make it easier to improve things down the line.

Also got a few other things done

  • removed set_task_progress references
  • deleted docker-compose.prod.yaml
  • moved Slack Block Kit to its own sub-package
  • removed unnecessary environment variables

Why are we doing this

Want to take advantage of newer Slack features

How should this be tested

Changed internals, end-to-end functionality is the same. Although I'm not quite sure how to test Slack Block kit. Maybe jest-esque tests?

Migrations

n/a

Dependencies

n/a

Callouts

  • still figuring out the best way to interact with Block Kit
  • hacked together tests to make things work; these tests are very flaky and depend a bit too much on our implementation
    • need to think of how to use and test Block Kit

@alysivji alysivji merged commit 61b8b7d into busy-beaver-dev:master Apr 18, 2020
@alysivji alysivji deleted the revamp-github-summary-ui branch April 18, 2020 23:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant