Skip to content
This repository has been archived by the owner on Oct 21, 2024. It is now read-only.

Remove Token Authentication Logic #255

Merged
merged 2 commits into from
Apr 19, 2020

Conversation

alysivji
Copy link
Member

What does this do

  • Delete the ApiUser model which was used to hold API Tokens
  • Remove @authentication_required decorator -- do not need it anymore
    • if we do need it again, can always add this code back in

Why are we doing this

  • Removing dead code from the codebase

How should this be tested

Do tests pass? We are good.

Migrations

Removing a column and deleting a table.

Dependencies

n/a

Callouts

n/a

@codecov-io
Copy link

Codecov Report

Merging #255 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #255      +/-   ##
==========================================
- Coverage   97.27%   97.20%   -0.07%     
==========================================
  Files          67       65       -2     
  Lines        1760     1716      -44     
==========================================
- Hits         1712     1668      -44     
  Misses         48       48              
Impacted Files Coverage Δ
busy_beaver/models/__init__.py 100.00% <ø> (ø)
busy_beaver/models/task.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10b613e...94ddd20. Read the comment docs.

@alysivji alysivji merged commit 71b3479 into busy-beaver-dev:master Apr 19, 2020
@alysivji alysivji deleted the remove-api-auth branch April 19, 2020 05:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants