Skip to content
This repository has been archived by the owner on Oct 21, 2024. It is now read-only.

Flash app messages to user; users can only upload pictures #322

Merged
merged 7 commits into from
Sep 22, 2020

Conversation

alysivji
Copy link
Member

@alysivji alysivji commented Sep 19, 2020

Closes #303

What does this do

We were using jsonify to pass information back to the user. This was a hack until we figured out how to add messages to our flask templates.

Restrict the file types users can upload to .jpg, .jpeg, .png

Why are we doing this

Improve user experience

How should this be tested

Tested locally to see if messages come thru; it's good

Migrations

n/a

Dependencies

n/a

Callouts

n/a

@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2020

Codecov Report

Merging #322 into master will decrease coverage by 0.05%.
The diff coverage is 65.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #322      +/-   ##
==========================================
- Coverage   92.48%   92.42%   -0.06%     
==========================================
  Files          71       71              
  Lines        2394     2403       +9     
==========================================
+ Hits         2214     2221       +7     
- Misses        180      182       +2     
Impacted Files Coverage Δ
busy_beaver/apps/web/views.py 77.59% <57.89%> (-0.19%) ⬇️
busy_beaver/apps/web/forms.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0adeae3...1490daf. Read the comment docs.

@alysivji alysivji changed the title Flash messages to let the user know what the application is doing Flash messages app messages to user; users can only upload pictures Sep 22, 2020
@alysivji alysivji changed the title Flash messages app messages to user; users can only upload pictures Flash messages app messages; users can only upload pictures Sep 22, 2020
@alysivji alysivji changed the title Flash messages app messages; users can only upload pictures Flash app messages to user; users can only upload pictures Sep 22, 2020
@alysivji alysivji merged commit 837fe43 into busy-beaver-dev:master Sep 22, 2020
@alysivji alysivji deleted the 303-flash-message branch September 22, 2020 18:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flash message
2 participants