Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sso_*: various documentation additions #315

Merged
merged 4 commits into from
Jul 6, 2021

Conversation

Jusshersmith
Copy link
Contributor

@Jusshersmith Jusshersmith commented Jun 29, 2021

  • As described in Broken link in docs #302, we're pointing to a file that no longer exists.

  • In the quickstart, UPSTREAM_CONFIGSFILEshould be UPSTREAM_CONFIGFILE (note the 'S' has been removed in 'CONFIGFILE'). Unless corrected, the quickstart results in Misdirected Request.

    ConfigsFile string `mapstructure:"configfile"`

  • Some general touchups of documentation in docs/sso_config.md

  • Creation of adocs/sso_proxy_config.md file, containing all available configuration variables for sso_proxy (the equivalent sso_auth file is here. For reference, a lot of these descriptions existed once upon a time here:

    // Options are configuration options that can be set by Environment Variables
    // Port - int - port to listen on for HTTP clients
    // ProviderURLString - the URL for the provider in this environment: "https://sso-auth.example.com"
    // ProxyProviderURLString - the internal URL for the provider in this environment: "https://sso-auth-int.example.com"
    // UpstreamConfigsFile - the path to upstream configs file
    // Cluster - the cluster in which this is running, used for upstream configs
    // Scheme - the default scheme, used for upstream configs
    // SkipAuthPreflight - will skip authentication for OPTIONS requests, default false
    // DefaultAllowedEmailDomains - csv list of emails with the specified domain to authenticate. Use * to authenticate any email
    // DefaultAllowedEmailAddresses - []string - authenticate emails with the specified email address (may be given multiple times). Use * to authenticate any email
    // DefaultAllowedGroups - csv list of default allowed groups that are applied to authorize access to upstreams. Will be overridden by groups specified in upstream configs.
    // DefaultProviderSlug - the provider that upstreams should use by default. Provider must exist within `sso_auth`. ie: "google"
    // ClientID - the OAuth Client ID: ie: "123456.apps.googleusercontent.com"
    // ClientSecret - The OAuth Client Secret
    // DefaultUpstreamTimeout - the default time period to wait for a response from an upstream
    // DefaultUpstreamTCPResetDeadline - the default time period to wait for a response from an upstream
    // TCPWriteTimeout - http server tcp write timeout - set to: max(default value specified, max(upstream timeouts))
    // TCPReadTimeout - http server tcp read timeout
    // CookieName - name of the cookie
    // CookieSecret - the seed string for secure cookies (optionally base64 encoded)
    // CookieDomain - an optional cookie domain to force cookies to (ie: .yourcompany.com)*
    // CookieExpire - expire timeframe for cookie
    // CookieSecure - set secure (HTTPS) cookie flag
    // CookieHTTPOnly - set HttpOnly cookie flag
    // PassAccessToken - send access token in the http headers
    // Provider - OAuth provider
    // DefaultProviderSlug - OAuth provider slug, used internally to identity a specific provider
    // Scope - OAuth scope specification
    // SessionLifetimeTTL - time to live for a session lifetime
    // SessionValidTTL - time to live for a valid session
    // GracePeriodTTL - time to reuse session data when provider unavailable
    // RequestLoging - boolean whether or not to log requests
    // StatsdHost - host addr for statsd client to listen on
    // StatsdPort - port for statsdclient to listen on
    // ShutdownTimeout - maximum time to wait for in-flight HTTP requests to complete before shutdown

@codecov
Copy link

codecov bot commented Jun 29, 2021

Codecov Report

Merging #315 (8071ac0) into main (b008111) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #315   +/-   ##
=======================================
  Coverage   62.73%   62.73%           
=======================================
  Files          58       58           
  Lines        4286     4286           
=======================================
  Hits         2689     2689           
  Misses       1382     1382           
  Partials      215      215           
Impacted Files Coverage Δ
internal/proxy/configuration.go 89.80% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b008111...8071ac0. Read the comment docs.

@Jusshersmith Jusshersmith changed the title sso_*: minor documentation fixes sso_*: various documentation additions Jul 2, 2021
@Jusshersmith Jusshersmith force-pushed the jusshersmith-touchup-docs-post-3.0.0 branch from 21236f2 to 1f428bf Compare July 2, 2021 12:49
@Jusshersmith Jusshersmith added docs Documentation and removed in progress labels Jul 2, 2021
docs/sso_config.md Outdated Show resolved Hide resolved
benjsto
benjsto previously approved these changes Jul 2, 2021
@Jusshersmith Jusshersmith merged commit a1b1b74 into main Jul 6, 2021
@Jusshersmith Jusshersmith deleted the jusshersmith-touchup-docs-post-3.0.0 branch July 6, 2021 14:22
@Jusshersmith Jusshersmith mentioned this pull request Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants