Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panel onResize and onCollapse props should be called after mount #75

Closed
bvaughn opened this issue Jan 10, 2023 · 1 comment · Fixed by #76
Closed

Panel onResize and onCollapse props should be called after mount #75

bvaughn opened this issue Jan 10, 2023 · 1 comment · Fixed by #76
Assignees
@bvaughn

Comments

@bvaughn
Copy link
Owner

bvaughn commented Jan 10, 2023

Currently these callbacks are only triggered after a user-initiated resize. Combining this with the auto-save behavior leads to an ambiguous mount scenario: is the panel collapsed or not? what's the initial size?
@bvaughn bvaughn self-assigned this Jan 10, 2023
This was referenced Jan 10, 2023
Closed
Merged
bvaughn added a commit that referenced this issue Jan 10, 2023
@bvaughn
Merge pull request #76 from /issues/75
5024008 
Panel and PanelGroup callbacks always called after mount
@bvaughn
Copy link
Owner Author

bvaughn commented Jan 10, 2023

Released in 0.0.32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bvaughn bvaughn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Panel and PanelGroup callbacks always called after mount bvaughn/react-resizable-panels
1 participant
@bvaughn