-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to Preconstruct #61
Conversation
"plugins": [ | ||
"@babel/plugin-proposal-class-properties", | ||
["@babel/plugin-proposal-class-properties", { "loose": true }], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this allows you to skip some Babel helpers from being injected into the output
@@ -1,6 +1,5 @@ | |||
{ | |||
"compilerOptions": { | |||
"esModuleInterop": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's best not to use this option when building libraries - it might "taint" the dependency and force all of the consumers to also use this option
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This particular package wasn't actually prone to this, so it's fine right now.
Thank you! 🙇🏼 |
I think this change broke the test target:
My bad for not having tests run on PRs for this project 💩 |
I will look into this soon |
This fixes it: diff --git a/jest.config.js b/jest.config.js
index bd9f347..5352e83 100644
--- a/jest.config.js
+++ b/jest.config.js
@@ -1,5 +1,15 @@
/** @type {import('ts-jest').JestConfigWithTsJest} */
module.exports = {
+ globals: {
+ "ts-jest": {
+ tsconfig: {
+ allowJs: true,
+ },
+ },
+ },
preset: "ts-jest",
testMatch: ["**/*.test.{ts,tsx}"],
+ transform: {
+ "^.+\\.[tj]sx?$": "ts-jest",
+ },
}; |
Published in 1.0.19 |
No description provided.