-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding direction to overscanIndicesGetter #629
Conversation
Mind updating the docs as well to list the new parameter? 😄 |
Like that? |
Thanks, but not quite. Update the section below that the hyperlink refers to ( |
Im sorry, I dont understand. Im happy to make a change if you can elaborate. |
I was just clarifying that- by enabling horizontal scrolling- you're using The reference I made about width being 100% is here. |
Brian, I think we got our conversations mixed. This pull request is for my upgrade to the overscanIndicesGetter. Your last comment seems like it was meant for issue #630. Im happy to update this pull request with better documentation if you can elaborate on what changes you want me to make. |
lol yes sorry. I was responding via email client and I assumed your response was to my most recent comment on the issue. Sorry! Go look at the |
👍 Thanks |
9.4.0 was just released with this feature. Thank you for your contribution! I listed you in the 9.4.0 release notes. |
Fixes #627 by adding direction to the overscanIndicesGetter