support scroll interaction on fixed rows/cols #708
Conversation
Is there a reason this is just a POC and not something you would want merged and released? Edit: Looks like there's an issue with the scrollbar overflow/padding in the fixed column/row that enables you to scroll too far. Maybe this is what you were concerned about? |
|
Not really, haven't thought too hard about it, wanted to spur some discussion around it first. I'm totally ok with it being merged and released.
… On Jul 8, 2017, at 18:55, Brian Vaughn ***@***.***> wrote:
please remember that this is just a POC to move the discussion forward for those who need this type of functionality.
Is there a reason this is just a POC and not something you would want merged and released?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Gotcha. Thanks for the update. I have noticed one issue (which I edited my previous comment to mention). I'll take a stab at resolving it. If it doesn't turn out to be too complicated. If it does, I may pass this PR back to you to look into it. Edit: Fortunately I think I have a reasonable solution for the scrollbar issue. Should be okay to move forward with this PR. |
|
Thank you for this contribution. I'm really glad to see how well this feature works. It's been requested a few times. I'm sorry it took me so long to review it. I've been busy. This feature has just been released in version 9.9.0 of the library and I've given you credit in the CHANGELOG. |
this PR provides opt-in support for scroll interaction on Grids that have fixed columns or rows.
here is a live demo of it working: https://goo.gl/xKCYBk
use Chrome DevTools device toolbar to view the site on a smaller device to try it out
please remember that this is just a POC to move the discussion forward for those who need this type of functionality.
enjoy all the scrollbars