Detect non-window element resize

[TrySound]

@bvaughn can this feature be minor?

[codecov-io]

Codecov Report

Merging #918 into master will decrease coverage by 0.06%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master     #918      +/-   ##
==========================================
- Coverage   89.93%   89.87%   -0.07%     
==========================================
  Files          57       57              
  Lines        1620     1630      +10     
==========================================
+ Hits         1457     1465       +8     
- Misses        163      165       +2

Impacted Files	Coverage Δ
source/WindowScroller/WindowScroller.js	85.24% <85.71%> (-1.03%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1936f5b...7f72c44. Read the comment docs.

[bvaughn]

I actually think this is fine for a bugfix.

[bvaughn]

This doesn't handle the case where the scrollElement prop changes from window to !window (or vice versa) within the life of the instance. I don't know if that's ever going to actually happen though. 😄

[TrySound]

Done

[TrySound]

We can use now or in the future resize-observer-polyfill. It's quite nice and have types. However not sure its strategy is also efficient as current implementation. Chrome promises to enable it by default in 64.

[bvaughn]

Yeah. I make mention of maybe using that in the next major release in the umbrella notes issue. Need to think about it more before deciding for certain.

…

On Tue, Dec 26, 2017 at 9:51 PM Bogdan Chadkin ***@***.***> wrote: We can use now or in the future https://github.com/que-etc/resize-observer-polyfill <http://resize-observer-polyfill>. It's quite nice and have types. However not sure its strategy it is also efficient as current implementation. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#918 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABzncbcxQN32_p2Ea1H8lT8MI3dYYdLks5tEdrZgaJpZM4RM9Pq> .