Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WindowScroller scrollElement prop types for window #948

Merged
merged 2 commits into from
Jan 5, 2018

Conversation

TrySound
Copy link
Contributor

@TrySound TrySound commented Jan 5, 2018

Seems like I accidentally overrided #939 with latter merge.

@codecov-io
Copy link

codecov-io commented Jan 5, 2018

Codecov Report

Merging #948 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #948   +/-   ##
=======================================
  Coverage   90.37%   90.37%           
=======================================
  Files          57       57           
  Lines        1632     1632           
=======================================
  Hits         1475     1475           
  Misses        157      157
Impacted Files Coverage Δ
source/WindowScroller/WindowScroller.js 98.41% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4496687...1d9ac95. Read the comment docs.

@TrySound TrySound merged commit 1bb0ec7 into master Jan 5, 2018
@TrySound TrySound deleted the fix-window-scroller-prop-types-again branch January 5, 2018 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants