Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run server-side rendering tests under pure node #953

Merged
merged 1 commit into from
Jan 6, 2018
Merged

Run server-side rendering tests under pure node #953

merged 1 commit into from
Jan 6, 2018

Conversation

TrySound
Copy link
Contributor

@TrySound TrySound commented Jan 6, 2018

@TrySound TrySound requested a review from bvaughn January 6, 2018 16:10
@codecov-io
Copy link

Codecov Report

Merging #953 into master will decrease coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #953      +/-   ##
==========================================
- Coverage   90.39%   90.33%   -0.06%     
==========================================
  Files          57       57              
  Lines        1634     1635       +1     
==========================================
  Hits         1477     1477              
- Misses        157      158       +1
Impacted Files Coverage Δ
source/WindowScroller/WindowScroller.js 98.48% <100%> (+0.02%) ⬆️
source/WindowScroller/utils/dimensions.js 95% <0%> (-5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a73141...607ad8c. Read the comment docs.

bvaughn
bvaughn approved these changes Jan 6, 2018
View reviewed changes
Copy link
Owner

@bvaughn bvaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oooh! Exciting! 😍

@TrySound TrySound merged commit 0be33a3 into master Jan 6, 2018
@TrySound TrySound deleted the ssr-tests branch January 6, 2018 17:18
@dependencies dependencies bot mentioned this pull request Jan 7, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bvaughn bvaughn bvaughn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TrySound @codecov-io @bvaughn