Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle case when number of element reduces in list #138

Merged
merged 2 commits into from
Feb 19, 2019

Conversation

iamsolankiamit
Copy link
Contributor

No description provided.

@bvaughn
Copy link
Owner

bvaughn commented Feb 18, 2019

Can you include a repro that fails before this change is made?

@iamsolankiamit
Copy link
Contributor Author

@bvaughn
Copy link
Owner

bvaughn commented Feb 18, 2019

I see. Thanks for sharing.

I agree with you that this looks like a bug. I'd like to add a unit test for it to prevent a regression. I'm pretty tired tonight. I'll take another look in the morning.

@bvaughn bvaughn merged commit 3a398a1 into bvaughn:master Feb 19, 2019
@bvaughn
Copy link
Owner

bvaughn commented Feb 19, 2019

This fix has been released with version 1.5.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants