Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove overflow:hidden from inner container #56

Merged
merged 1 commit into from
Sep 13, 2018
Merged

Remove overflow:hidden from inner container #56

merged 1 commit into from
Sep 13, 2018

Conversation

souporserious
Copy link
Contributor

Fixes #55 and allows the use of position: sticky. I tested all major browsers and back to IE11 and all seems well.

bvaughn
bvaughn approved these changes Sep 13, 2018
View reviewed changes
Copy link
Owner

@bvaughn bvaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

@bvaughn bvaughn merged commit 85031b2 into bvaughn:master Sep 13, 2018
@souporserious souporserious deleted the remove-inner-wrapper-overflow branch September 13, 2018 20:42
@souporserious
Copy link
Contributor Author

Thanks Brian! ❤️

@bvaughn
Copy link
Owner

bvaughn commented Oct 1, 2018

This change has been included with the 1.2.0 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bvaughn bvaughn bvaughn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@souporserious @bvaughn