Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test and fix for flowtype for children #77

Merged
merged 4 commits into from
Oct 29, 2018

Conversation

nicholas-l
Copy link
Contributor

I think this fixes it but I'm not sure.

Fixes #76

@bvaughn
Copy link
Owner

bvaughn commented Oct 25, 2018

Hm. I think this change looks like a good one to make, but the Flow failure still happens for me (in this branch, as well as in a CRA app). Looks like it's failing on CI as well.

We should make a similar change in createGridComponent too.

@nicholas-l
Copy link
Contributor Author

Fixed the problem :) and have updated GridComponent to be the same.

Copy link
Owner

@bvaughn bvaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Thanks! 👍

@bvaughn bvaughn merged commit 7960199 into bvaughn:master Oct 29, 2018
@bvaughn
Copy link
Owner

bvaughn commented Oct 29, 2018

This fix has been published in v1.2.2!

@nicholas-l nicholas-l deleted the fix-flow-type branch March 18, 2019 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flow Type issue with PureComponent
2 participants