forked from facebook/react
-
-
Notifications
You must be signed in to change notification settings - Fork 6
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix DevTools profiling bailout check
I recently changed DevTools to filter certain types of empty commits (facebook#17253) to avoid showing them in the Profiler UI. I believe this change lead to an increase in the number of 'Could not find node with id...' errors being reported for the Profiler. This commit updates flushPendingEvents() to mirror the bailout check I added previously. This prevents one cause of operations and commit data mismatching that could cause this error. I am convinced there is another case still that I need to fix though.
- Loading branch information
Brian Vaughn
committed
Jan 2, 2020
1 parent
b05cd61
commit 60aa3fa
Showing
2 changed files
with
22 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters