Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Commit

Permalink
Merge branch 'refactor'
Browse files Browse the repository at this point in the history
  • Loading branch information
megasanjay committed Sep 27, 2021
2 parents 6ea8a1c + 5bfb5f7 commit d372750
Show file tree
Hide file tree
Showing 23 changed files with 6,947 additions and 6,883 deletions.
28 changes: 27 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,20 @@ All notable changes to SODA will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## v4.8.0 - 2021-09-13

### Feature additions:

- Added onboarding for subjects and samples tables.
- Added validation checks for verifying the backend and front end app versions.
- Refactored large parts of the code performane improvements.
- Added onboarding for step 3 of the Organize dataset process.

### Bug fixes:

- Importing subjects + samples files have been adapted to new strain/species UI change
- Changed the activation point for illegal character checks.

## v4.7.1 - 2021-09-13

### Bug fixes:
Expand All @@ -14,12 +28,16 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed Contributor Role suggestion dropdown bug that only showed a maximum of 5 items.
- Fixed `Start over` functions for subjects and samples files to adapt to the new Add strains and Add species UI change.

### Known issues:

- There is a bug with removing dataset permissions using both SODA and Pennsieve. If you want to remove your own permission from a dataset, another user with either 'Manager' or 'Owner' permissions must remove you from the dataset. This is an issue with Pennsieve's backend system and will be updated soon.

## v4.7.0 - 2021-08-31

### Feature additions:

- Changed user interface for `Prepare metadata - Create submission.xlsx file`. This user interface was changed to be even more user-friendly and consistent with the user interface of `Prepare metadata - Create dataset_description.xlsx file`.
- Added user oonboarding tutorials to help first time users of the app understand Step 3 of Organizing datasets better.
- Added user onboarding tutorials to help first time users of the app understand Step 3 of Organizing datasets better.
- Changed strain and species retrieval under Create subjects.xlsx and Create samples.xlsx from input search to button clicks.
- Changed all of the remaining status elements into Sweetalert popups for consistency in the app.
- Added an option to replace metadata files when generating if one already exists at the destination folder.
Expand All @@ -35,6 +53,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed a bug where loading an award from Airtable would require two attempts.
- Fixed a bug where macOS version of SODA would run the pre-check message everytime the app lost focus.

### Known issues:

- There is a bug with removing dataset permissions using both SODA and Pennsieve. If you want to remove your own permission from a dataset, another user with either 'Manager' or 'Owner' permissions must remove you from the dataset. This is an issue with Pennsieve's backend system and will be updated soon.

## v4.6.2 - 2021-08-13

### Bug fixes:
Expand All @@ -44,6 +66,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed margin bug for Details display (Prepare dataset -> Step 3).
- Added warning for when a user imports an existing metadata file. If any values from the file does not follow SPARC standard values, they will be ignored and not imported onto SODA for edits.

### Known issues:

- There is a bug with removing dataset permissions using both SODA and Pennsieve. If you want to remove your own permission from a dataset, another user with either 'Manager' or 'Owner' permissions must remove you from the dataset. This is an issue with Pennsieve's backend system and will be updated soon.

## v4.6.1 - 2021-08-06

### Bug fixes:
Expand Down
2 changes: 1 addition & 1 deletion src/assets/css/main.css
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ button[disabled] {
}

button[data-id="bf_list_users"],
button[data-id="bf_list_roles"],
button[data-id="bf_list_roles_user"],
button[data-id="bf_list_teams"],
button[data-id="bf_list_roles_team"] {
border: 1px solid rgba(34, 36, 38, 0.15);
Expand Down
Binary file added src/file_templates/old_dataset_description.xlsx
Binary file not shown.
4 changes: 3 additions & 1 deletion src/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -293,11 +293,13 @@
});
</script>

<script src="scripts/popper.min.js"></script>
<script src="scripts/others/popper.min.js"></script>
<script src="node_modules/fomantic-ui/dist/components/accordion.js"></script>
<script src="node_modules/jstree/dist/jstree.min.js"></script>
<script src="node_modules/bootstrap/dist/js/bootstrap.bundle.min.js"></script>
<script src="node_modules/@tarekraafat/autocomplete.js/dist/autoComplete.js"></script>
<script src="node_modules/sweetalert2/dist/sweetalert2.min.js"></script>

<script src="./scripts/others/renderer.js" type="text/javascript"></script>
</body>
</html>
2 changes: 1 addition & 1 deletion src/main.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ require("v8-compile-cache");
const { ipcMain } = require("electron");
const { autoUpdater } = require("electron-updater");
const { JSONStorage } = require("node-localstorage");
const { trackEvent } = require("./scripts/analytics");
const { trackEvent } = require("./scripts/others/analytics");
const { fstat } = require("fs");

log.transports.console.level = false;
Expand Down
6 changes: 3 additions & 3 deletions src/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "SODA",
"productName": "SODA",
"version": "4.7.1",
"version": "4.8.0",
"description": "Keep Calm and Curate ",
"main": "main.js",
"scripts": {
Expand All @@ -16,7 +16,7 @@
},
"repository": {
"type": "git",
"url": "https://github.com/bvhpatel/SODA.git"
"url": "https://github.com/fairdataihub/SODA-for-SPARC.git"
},
"build": {
"appId": "com.calmi2.soda",
Expand Down Expand Up @@ -58,7 +58,7 @@
},
"publish": {
"provider": "github",
"repository": "https://github.com/bvhpatel/SODA.git"
"repository": "https://github.com/fairdataihub/SODA-for-SPARC.git"
}
},
"keywords": [],
Expand Down
6 changes: 6 additions & 0 deletions src/pysoda/api.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@
import sys
import zerorpc

MIN_SODA_VERSION = "4.8.0"

class SodaApi(object):

### import milestone document
Expand Down Expand Up @@ -364,6 +366,10 @@ def api_get_pennsieve_api_key_secret(self, email, password, keyname=SODA_SPARC_A
# except Exception as e:
# raise e

### Check Login to Python Server
def api_version_check(self):
return MIN_SODA_VERSION

### Check Login to Python Server
def echo(self, text):
"""echo any text"""
Expand Down
Loading

0 comments on commit d372750

Please sign in to comment.