Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql2o implementation #7

Open
bwajtr opened this issue Nov 29, 2016 · 3 comments
Open

sql2o implementation #7

bwajtr opened this issue Nov 29, 2016 · 3 comments
Labels

Comments

@bwajtr
Copy link
Owner

bwajtr commented Nov 29, 2016

See http://www.sql2o.org/

There is integration with Spring too: http://www.sql2o.org/docs/spring/

@bwajtr
Copy link
Owner Author

bwajtr commented Dec 1, 2016

I took a look at sql2o and considered it for implementation, but for now sql2o does not support external transaction management -> namely it does not integrate with Spring transactions management. That's a huge no go for me so I won't even try to implement all the scenarios...

There is a quite old pull request with support for Spring transactions (aaberg/sql2o#153) so I propose to reconsider sql2o once this pull request is accepted.

bwajtr pushed a commit that referenced this issue Dec 1, 2016
…ng transactions -> just mentioned that in README
@bwajtr bwajtr added the waiting label Dec 1, 2016
@sajjadG
Copy link

sajjadG commented Nov 5, 2017

Hi @bwajtr
I was looking for the best option to use instead of ORM and I found your project. awesome. Your comparisons helped me a lot. Thanks.

I checked aaberg/sql2o#153 and they've closed the PR with this comment (by @xiexed):

I think that after merging of #264 there is no sense in this pull request anymore.
If someone wants to use Spring transactions management - it 's a question of one class with few lines of code. But I don't think that there is much sense to ship such Spring related class with Sql2o.

I wonder if this change to sql2o resolves this issue and make it ready to added to your comparison?

@bwajtr bwajtr added planned and removed waiting labels Nov 6, 2017
@bwajtr
Copy link
Owner Author

bwajtr commented Nov 6, 2017

Hi @sajjadG, thanks for pointing this out. I'll definitely take a look at sql2o again and implement it. I did the comparisons about a year ago so I think it's time to actually upgrade&review all of the implementations...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants