feat: Use serde_repr to (de)serialize Mode and Status enums. #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the manual deserialization implementation for the
Mode
enum to use the serde_repr crate. Due to this change, the behavior on deserialization is modified. Before all unknown values where mapped toMode::NoFix
. Now only the 0 is mapped toMode::Unknown
as defined in the gpsd json protocol. Non-defined values result in a serialization error.The status field is now also supported as
Status
enum. Implementation aligns with the new implementation for theMode
enum.The changes would required increasing the major version.
Initial motiviation for the changes was that the
serialize
feature was not working due to the fact that there was notSerialize
implementation for theMode
enum.