Breaking changes: Support gpsd 3.25 #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a sweeping update to many of the types to support fields added in versions of gpsd later than 3.17. I broadly tried to maintain backwards compatibility in terms of the decoding of messages and types used by downstream libraries, but the same cannot be said for anyone using this library to construct commands as it will allow them to add fields that are "invalid" for older gpsd versions.
There are "a few" breaking changes in here, the most fundamental ones being the addition of
#[non_exhaustive]designators on many of the structs and enums to account for the potential addition of more fields in the future.I also added a rustfmt policy that should help a little.
This PR includes the content from PRs #17 and #16, I'm not entirely sure if that was a good idea, sorry if that makes it a headache.