Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to run installed tools? #52

Closed
cszatmary opened this issue Dec 8, 2020 · 2 comments · Fixed by #56
Closed

How to run installed tools? #52

cszatmary opened this issue Dec 8, 2020 · 2 comments · Fixed by #56
Labels
enhancement New feature or request

Comments

@cszatmary
Copy link

After I install tools with bingo get what is the intended way to run them?

It would be nice if there was a command where given a tool name it would find the path to the installed tool and execute it.

Example of what this might look like:

bingo run golangci-lint run
bwplotka added a commit that referenced this issue Dec 27, 2020
Fixes #52

Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
bwplotka added a commit that referenced this issue Dec 27, 2020
Fixes #52

Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
@bwplotka bwplotka added the enhancement New feature or request label Dec 27, 2020
@bwplotka
Copy link
Owner

Hey, sorry for the delayed response, I am lagging behind GH notifications 😱

This is a valid question overall. I think it was not well explained. I improved docs here: #56 @cszatmary does it make sense? 🤗

There are some tools that wanted to support something like run command, but I believe there is no need for something like this. We can totally use native OS tools like shell and its variable to achieve the same, no? See this doc.

To sum up, I see 3 reasons why using the native way might be better:

  • We don't reproduce work / reinvent the wheel
  • Supporting run well actually is not that easy to write. Passing arguments by CLI to underlying shell execution is actually incredibly hard (trust me, I tried in my previous job). There are thousands of nuances (e.g how to differentiate between bingo flags and passed flags? -- is the native way, but it also means you cannot use the same commands anymore.)
  • Would nice to maintain in bingo [do one thing, and do it well] philosophy (https://hackaday.com/2018/09/10/doing-one-thing-well-the-unix-philosophy/)

Hope this makes sense (:

bwplotka added a commit that referenced this issue Dec 27, 2020
Fixes #52

Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
bwplotka added a commit that referenced this issue Dec 27, 2020
Fixes #52

Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
bwplotka added a commit that referenced this issue Dec 27, 2020
Fixes #52

Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
bwplotka added a commit that referenced this issue Dec 27, 2020
Fixes #52

Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
bwplotka added a commit that referenced this issue Dec 27, 2020
Fixes #52

Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
bwplotka added a commit that referenced this issue Dec 27, 2020
Fixes #52

Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
@wmcnamee-coreweave
Copy link

ya, I'm in the same boat here. I just found out about this tool, which seems good, except it would be great if symlinks were made instead of having to source the variables.env and use all caps TOOL_NAME. I essentially need tool installs to be transparent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants